BUG: SetTypewriterSpeed Method in StandardUISubtitleControls

Announcements, support questions, and discussion for the Dialogue System.
Post Reply
WeiYiHua
Posts: 7
Joined: Mon Mar 25, 2024 10:27 pm

BUG: SetTypewriterSpeed Method in StandardUISubtitleControls

Post by WeiYiHua »

v 2.2.44.1
The SetTypewriterSpeed method at Scripts\UI\Standard\Dialogue\StandardUISubtitleControls.cs Line: 817 seems to be improperly implemented. The current method is as follows:

Code: Select all

public virtual void SetTypewriterSpeed(float charactersPerSecond)
{
    for (int i = 0; i < m_builtinPanels.Count; i++)
    {
        if (m_builtinPanels[i] != null) TypewriterUtility.GetTypewriterSpeed(m_builtinPanels[i].subtitleText);
    }
    if (m_defaultNPCPanel != null && !m_builtinPanels.Contains(m_defaultNPCPanel)) TypewriterUtility.GetTypewriterSpeed(m_defaultNPCPanel.subtitleText);
    if (m_defaultPCPanel != null && !m_builtinPanels.Contains(m_defaultPCPanel)) TypewriterUtility.GetTypewriterSpeed(m_defaultPCPanel.subtitleText);
}
User avatar
Tony Li
Posts: 20632
Joined: Thu Jul 18, 2013 1:27 pm

Re: BUG: SetTypewriterSpeed Method in StandardUISubtitleControls

Post by Tony Li »

Thank you. That has been corrected in the upcoming version 2.2.45. It now correctly calls SetTypewriterSpeed. Here's a patch:

DS_SetTypewriterSpeedPatch_2024-04-37.unitypackage
Post Reply